Compatible with gitea and forgejo #226
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just tried this action and realized it does not work for me because THIS is missing (we have an on-prem enterprise github). Code looks good to me, good job! I suggest changing the title of the PR to "Make instance URL configurable to support other Git vendors or github enterprise on prem". Maybe this will make visibility better and quicken the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added compatibility with instances of other products that use this action. Now, keys should be correctly processed by comments, regardless of the domain on which the server is deployed. The domain is taken from the GITHUB_SERVER_URL variable. I tested it on forgejo and it works. It should work on gitea too, but I haven't tested it.